Liron Aravot has submitted this change and it was merged. Change subject: core: SerialChildCommandsExecutionCallback - consider command execution ...................................................................... core: SerialChildCommandsExecutionCallback - consider command execution When setting the TaskGroupSuccess member to indicate whether the execution was succesful or not the command status should be taken into consideration as well and if the execute() method execution wasn't completed the task group success should be set to false as some logic maybe wasn't executed. Change-Id: I94079624e22c2e8f5dae84c8f1d54aeff65b8bf2 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94079624e22c2e8f5dae84c8f1d54aeff65b8bf2 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>