Allon Mureinik has submitted this change and it was merged. Change subject: core: VdsBrokerObjectsBuilder#numaNodeComparator ...................................................................... core: VdsBrokerObjectsBuilder#numaNodeComparator Clean up the code by using Comparator's function references instead of re-implementing this logic inline. As a side effect, this patch fixes a theoretical bug where the previous comparator violates java's contract for two VdsNumaNodes with the same index. Change-Id: Ifc834c26915cc1e7c3a8b3c103acfe8e1d6bd698 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc834c26915cc1e7c3a8b3c103acfe8e1d6bd698 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>