Martin Sivák has submitted this change and it was merged. Change subject: Document the Agent FSM using docstrings and autogenerate the graphviz sources ...................................................................... Document the Agent FSM using docstrings and autogenerate the graphviz sources This adds two special lines to state class docstrings: :transition[ destination]: description - describes transition from current class to destination - it is treated as staying in the current state when destination is not provided :transitions_from StateClass: - used to support inheritance, copies all transitions from StateClass to the current class This patch also adds a script that reads the state_machine.py and states.py modules and generates the fill graphviz source for the state machine. make fsm then generates the new source and png file with the state machine. Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850 Signed-off-by: Martin Sivak <msivak@redhat.com> --- M Makefile.am A build/build-aux/gen_gv.py M doc/agent-fsm.gv M ovirt_hosted_engine_ha/agent/state_machine.py M ovirt_hosted_engine_ha/agent/states.py 5 files changed, 258 insertions(+), 31 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server