Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Fix "getGroupedGlusterSwiftServices" ...................................................................... webadmin: Fix "getGroupedGlusterSwiftServices" According to findbugs this method creates a useless object: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT In this particular case it looks like a real issue. This patch fixes the method so that the created object isn't useless. Change-Id: I376286c566befcd369847ee871dc538a9cb631de Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, but someone else must approve Kanagaraj M: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I376286c566befcd369847ee871dc538a9cb631de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa@redhat.com> Gerrit-Reviewer: automation@ovirt.org