Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Fix potential NPE when in CheckboxColumn
......................................................................
webadmin: Fix potential NPE when in CheckboxColumn
getValue(object)) in checkboxColumn.render() might return null, resulting in
an NPE when used in if. Fix the if to handle null.
Note: this bug could only occur if a checkboxColumn is not editable
*and* it's value is null.
Change-Id: I26f688984083fbd6964972e79e50960b254c547b
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
Bug-Url:
https://bugzilla.redhat.com/1097754
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Vered Volansky: Verified
--
To view, visit
http://gerrit.ovirt.org/27726
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26f688984083fbd6964972e79e50960b254c547b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server