Change in ovirt-engine[master]: core: ExtensionsManager private globalContext

From Moti Asayag <masayag@redhat.com>:
Moti Asayag has submitted this change and it was merged. Change subject: core: ExtensionsManager private globalContext ...................................................................... core: ExtensionsManager private globalContext globalContext is used as an argument to synchronize. As per Java's best practices, it should be final, to avoid hard-to-detect race bugs. Change-Id: I90ff1735824fd44210faca7ba2e2832cfd0e2ff9 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ff1735824fd44210faca7ba2e2832cfd0e2ff9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review