Oved Ourfali has submitted this change and it was merged. Change subject: core: fix split function and its use for spice security channels ...................................................................... core: fix split function and its use for spice security channels Previous commit added the split function, but it didn't take into account what if the entries are not there at all (new install). It assumed they are there, as they would appear in the add section. Better implementation is not to assume that, creating the old entries with old value in install phase, or taking the original value from the DB in case of upgrade. Change-Id: I32b9b89c0c28180738b8532561e110fcd3e61d1b Signed-off-by: Oved Ourfali <oourfali(a)redhat.com&gt; --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 2 files changed, 24 insertions(+), 20 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32b9b89c0c28180738b8532561e110fcd3e61d1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt;