Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: UnPowerMock GetVmByVmIdQueryTest
......................................................................
core: UnPowerMock GetVmByVmIdQueryTest
Removed PowerMock dependecy from GetVmByVmIdQueryTest.
Before this patch, the test was not a good unit test - it did not test
just the query, but also VmHandler's functionallity, which should have
been tested separately.
This patch turns the test into a strict unit teset, which only test's
the query's functionallity, and this PowerMock is no longer needed.
Change-Id: Ieaf73c28f2321e564d9c9d336dbf33a89e7a2929
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmIdQuery.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmIdQueryTest.java
2 files changed, 10 insertions(+), 40 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit
http://gerrit.ovirt.org/4768
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaf73c28f2321e564d9c9d336dbf33a89e7a2929
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>