Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix storage QoS UI validation ...................................................................... webadmin: fix storage QoS UI validation The storage values weren't validated. Also added a check to allow setting total or read/write. Change-Id: Ia4f69ce1b7751e066c6a1e15f482805bbc7df16a Bug-Url: https://bugzilla.redhat.com/1168558 Signed-off-by: Gilad Chaplik <gchaplik@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/CpuQosParametersModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/QosModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/QosParametersModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosParametersModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 6 files changed, 25 insertions(+), 3 deletions(-) Approvals: Tomer Saban: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f69ce1b7751e066c6a1e15f482805bbc7df16a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server