Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Inline VolumeListModel#isOptionEnabledOnVolume ...................................................................... webadmin: Inline VolumeListModel#isOptionEnabledOnVolume This patch inlines VolumeListModel#isOptionEnabledOnVolume and the predicate it uses as part of the effort of removing Linq#IPredicate from the codebase. Besides cleaning up the code and making it easier to maintain, as an added bonus this patch employs the short-circuit noneMatch method instead of evaluating the predicate against all the options and only then checking if it matched none of them, providing a slight performance improvement. Change-Id: I3e004b0c2a536ec6520c6b4c64a31d34bedd74a4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e004b0c2a536ec6520c6b4c64a31d34bedd74a4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;