Martin Peřina has submitted this change and it was merged. Change subject: core: Correctly finish Remove VM Pool job ...................................................................... core: Correctly finish Remove VM Pool job For every VM in the pool removed, the endAction() of the corresponding RemoveVmCommand must be called. For this purpose, RemoveVmCommand must be parent command of all async tasks, not RemoveVmPoolCommand. Also, adding IDs of all async tasks to the return value of RemoveVmPoolCommand (RemoveVmCommand also needed to be fixed to add the IDs to the correct list if RemoveVmCommand is executed as internal command). Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257132 Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49e31a498cf57dc8a1b459c79fbe4566cd3d0e89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: automation@ovirt.org