From Allon Mureinik <amureini@redhat.com>:

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Fix AbstractRxTxRateColumn#makeSortable ...................................................................... webadmin: Fix AbstractRxTxRateColumn#makeSortable makeSortable's comparator violates the general contract of Java's Comparator in case both values return true for RxTxRateRenderer.isEmpty, RxTxRateRenderer.isZero or RxTxRateRenderer.isSmall. This patch uses the standard Comparator.comparing method to reimplement this comparator in a way that would not violate Java's contract. Change-Id: Ibed9c6505a70c015749816ee3e6785e52ef7103b Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractRxTxRateColumn.java 1 file changed, 4 insertions(+), 22 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75556 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibed9c6505a70c015749816ee3e6785e52ef7103b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>