Change in ovirt-engine[master]: core: if not dns address is provided, mark checkbox as invalid

From Tomas Jelinek <tjelinek@redhat.com>:
Tomas Jelinek has submitted this change and it was merged. Change subject: core: if not dns address is provided, mark checkbox as invalid ...................................................................... core: if not dns address is provided, mark checkbox as invalid Due to ghosts behavior, we cannot mark unset field in red, therefore checkbox enabling dns configuration will be marked as invalid in case dns configuration is requested (checkbox is checked) but not configuration is provided in following widgets. Change-Id: Idacf07dedff8fe374aab1505da6c909e9e6f0d3a Bug-Url: https://bugzilla.redhat.com/1451245 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/dnsconfiguration/DnsConfigurationModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 31 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idacf07dedff8fe374aab1505da6c909e9e6f0d3a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review