Oved Ourfali has submitted this change and it was merged. Change subject: core: adding login permissions ...................................................................... core: adding login permissions This patch adds the login action group, relevant to LoginUserCommand and LoginAdminCommand. In this patch: 1. Adding the action group. 2. Adding a "bottom" object type + object (used for the permissions check, as every object is the parent of bottom). If there is an object with permissions for a specific user, and the role contains the login action group, then the user can login to the system. Otherwise, the user won't be able to login. 3. Upgrade: The login action group will be added to every predefined role (except for the TemplateUser and the QuotaUser roles). 4. Common Stored procedures - added a new function that adds an action group to all the roles, except ones we would like to filter. 5. UI changes - add the new action group under system configuration in the configuration menu. Also, mark the login action group as a user action group in the UI. Change-Id: Ib86ec99739ff73fa500a9de6c056b324c353929c Signed-off-by: Oved Ourfali <oourfali@redhat.com> --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/create_functions.sql M backend/manager/dbscripts/multi_level_administration_sp.sql A backend/manager/dbscripts/upgrade/03_01_1230_add_login_action_group.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 19 files changed, 178 insertions(+), 23 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86ec99739ff73fa500a9de6c056b324c353929c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>