Einav Cohen has submitted this change and it was merged. Change subject: build: Fix gwt-debug target in Makefile ...................................................................... build: Fix gwt-debug target in Makefile Currently, gwt-debug target executes following command: mvn $(DEV_BUILD_FLAGS) ... This means DEV_BUILD_FLAGS can apply parameters that aren't relevant and/or shouldn't even be specified when launching GWT Developer Mode, such as: -Pgwtdraft [via DEV_BUILD_GWT_DRAFT] -Dgwt.userAgent [via DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS] Since DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS defaults to using Firefox (-Dgwt.userAgent=gecko1_8), if someone wants to debug GWT application in Chrome (or any other browser), he must override DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS with empty string, for example: make gwt-debug webadmin \ DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="" In other words, gwt-debug target shouldn't apply GWT-compile time parameters, such as -Dgwt.userAgent=... Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com>