Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: new role dialog
......................................................................
webadmin: new role dialog
- The New Role dialog layout was being messed up by
different locales if the text was too long. This patch
rearranges the popup dialog to use patternfly grids
for the layout and makes sure the text can grow
sufficiently to accomodate the different locales
Change-Id: I5db8fdcc2901dcc1820588f813cb5744323fb820
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml
2 files changed, 45 insertions(+), 59 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, but someone else must approve
Vojtech Szocs: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/37553
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5db8fdcc2901dcc1820588f813cb5744323fb820
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server