Allon Mureinik has submitted this change and it was merged. Change subject: core: optimize setVdsGroupCompatibilityVersion ...................................................................... core: optimize setVdsGroupCompatibilityVersion VDS and VM methods setVdsGroupCompatibilityVersion(Version) contain a false optimization that only updates the member if the value were to change. Since assignment in Java is much cheaper than equality checking, simply updating the value of the member, regardless of whether it changed or not, would be much faster than this so-called optimization. Change-Id: I0166fccf2188360b2e8812b462eb5c79d25aebe4 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0166fccf2188360b2e8812b462eb5c79d25aebe4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server