From Daniel Erez <derez@redhat.com>:

Daniel Erez has submitted this change and it was merged. Change subject: core: Enable disk transferring for users via REST. ...................................................................... core: Enable disk transferring for users via REST. This patch enables image transferring for not-admin users. Until now, it was prevented in the system due to two main reasons: 1. GetImageTransferByIdQuery was an Admin query, and is being called from image transfer REST commands. This patch changes it to a User query and makes the needed changes in the transfer DAO in terms of filtering, etc. 2. Transfer commands did not have any action group, making it unavailable for users with permissions to transfer an image. This patch defines those commands to belong to EDIT_DISK_PROPERTIE action group- which is the needed one to do a transfer. Change-Id: Icf8311d9d53ab88f7e3305fb8fa0ed4cd4ff078c Signed-off-by: Amit Aviram <aaviram@redhat.com> Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetImageTransferByIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDaoImpl.java M packaging/dbscripts/image_transfers_sp.sql 6 files changed, 34 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf8311d9d53ab88f7e3305fb8fa0ed4cd4ff078c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>