Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80711 ) Change subject: webadmin: VmSnapshotListModel PREVIEW snapshot checking ...................................................................... webadmin: VmSnapshotListModel PREVIEW snapshot checking In VmSnapshotListModel#setItems, every iteration of the loop checks if there's a snapshot which has the PREVIEW type. However, as the snapshots do not change throughout the loop, it could be checked only once, before the loop. This would both [arguably] clean up the code, but also provide a slight performance enhancement. Change-Id: I7aa3c21f4e5af89abfa0fb5413510785c73c1d5f Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aa3c21f4e5af89abfa0fb5413510785c73c1d5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;