Einav Cohen has submitted this change and it was merged. Change subject: webadmin: no localization for command buttons strings ...................................................................... webadmin: no localization for command buttons strings As a result of Idd623481d0eb77bfbaa1e8b3eec8b445020711c8 Command buttons' text strings must reside in the model, i.e. localization through the view is being ignored. Fixed AbstractUiCommandButton by updating button's text and title (tool-tip) according the the model only as a last resort (i.e. when no localization is available). (modified GuidePopupView to maintain the behavior of the original bug fix: https://bugzilla.redhat.com/850439) Change-Id: I186b5f3a812d34a30209998933c0617e9e182be7 Bug-Url: https://bugzilla.redhat.com/876955 Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I186b5f3a812d34a30209998933c0617e9e182be7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Alexey Chub <achub@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen@redhat.com>