Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveDiskSnapshots - sort images from parent to leaf ...................................................................... core: RemoveDiskSnapshots - sort images from parent to leaf When removing multiple disk snapshots that belongs to the same disk, the images should be sorted from parent to leaf (active). Sorting is needed since removing a child image and a parent image afterwards, might be invalid - as the parent will point to another child and when deletion is done in consecutive order there's a race condition between DB update and removing next parent. Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366 Bug-Url: https://bugzilla.redhat.com/1151841 Signed-off-by: Daniel Erez <derez(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759537f7c32fc9b19a968f32767bba633f3f3366 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server