Allon Mureinik has submitted this change and it was merged. Change subject: core: Test DestroyImageCheckCommand's ...................................................................... core: Test DestroyImageCheckCommand's This patch adds a test for DestroyImageCheckCommand's logic to check which volumes still exist. This patch contains: 1. Extracting the getFailedVolumeIds() method in DestroyImageCheckCommand, so it can intelligently be tested. 2. Adding DestroyImageCheckCommandTest to test the aforementioned getFailedVolumeIds(). Change-Id: I8633a9375216f559516c1f7f2e296dfc1bd679aa Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java 2 files changed, 91 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8633a9375216f559516c1f7f2e296dfc1bd679aa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>