Alona Kaplan has submitted this change and it was merged. Change subject: core: multiple tests & refactoring of HostSetupNetworksValidator.java ...................................................................... core: multiple tests & refactoring of HostSetupNetworksValidator.java This is a combination of 11 commits: ———————————————————————————————————— core: refactoring of HostSetupNetworksValidator.java • inlined variable in #validateNetworkExclusiveOnNics • renamed variable and extracted boolean condition in #networksUniquelyConfiguredOnHost • removed 'passed' variable in #validateNotRemovingUsedNetworkByVms • removed unnecessary continue in #getAttachmentsToConfigure • extracted validation of slaves into separate method from overgrown #validModifiedBonds • 'narrowed' visibility of #getVmInterfaceManager core: calculate attachmentsToConfigure only once. core: test for mtu validation core: tests for HostSetupNetworksValidator#notRemovingLabeledNetworks. core: tests for HostSetupNetworksValidator#validRemovedBonds core: unified field/param names. •unified field/param names •inlined unnecessary getter. core: tests for HostSetupNetworksValidator#validateNotRemovingUsedNetworkByVms core: tests for HostSetupNetworksValidator#networksUniquelyConfiguredOnHost core: tests for HostSetupNetworksValidator#validModifiedBonds • added tests • extracted creation of HostInterfaceValidator for mocking purposes • renamed two methods allowing to use them in different context as well. core: fixes & tests for HostSetupNetworksValidator#getAttachmentsToConfigure • getAttachmentsToConfigure did not return NetworkAttachments which were changed by the user. Implementation was entirely changed • added tests for this new configuration core: tests for HostSetupNetworksValidator#validateCustomProperties() ———————————————————————————————————— Change-Id: If921e9d74b54057e43708fc48f53f81b05293c71 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 1,201 insertions(+), 88 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/42856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If921e9d74b54057e43708fc48f53f81b05293c71 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: automation@ovirt.org