Roy Golan has submitted this change and it was merged. Change subject: scheduling: External scheduler cleanup and modernization ...................................................................... scheduling: External scheduler cleanup and modernization There were some changes to the overall engine and scheduling that is nice to have in the external scheduler logic. Most notably support for Java 8 and CDI. The first change is the CDI support. This patch adds the ExternalSchedulerBroker interface and makes the implementation available as @Singleton. Return types of some methods were converted from Pair of Pairs and such to a nice Java class like ScoringResult. Another change is the added support for per-unit weight results. The external scheduler can now report raw weight data for each host and for each policy unit to utilize the selector support we now have in scheduler. Old summed up weight record: [host id, already factored weight] New raw weight record: [host id, raw weight, policy unit name] Both summed up and raw results are supported to maintain compatibility. Change-Id: Id333b614eccad51ca7a61b344df59e143f1bda89 Signed-off-by: Martin Sivák <msivak@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ScoringResult.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/WeightResultEntry.java 8 files changed, 139 insertions(+), 72 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id333b614eccad51ca7a61b344df59e143f1bda89 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar@redhat.com> Gerrit-Reviewer: Martin Sivák <msivak@redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey@redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>