Arik Hadas has submitted this change and it was merged. Change subject: core: handle failed internal migrations properly ...................................................................... core: handle failed internal migrations properly InternalMigrateVmCommand used to always do setSucceeded(true) no matter if the migration was triggered successfully or not (MigrateVmCommand does not throw exception in the execute phase in case of failures). This patch changes InternalMigrateVmCommand to set the result properly and changes MaintenanceVdsCommand to check whether the migration has failed or not properly, by checking its getSucceeded(). Change-Id: I4289365a1aceb02adea5029beac1547e024ebca4 Bug-Url: https://bugzilla.redhat.com/1332039 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 2 files changed, 8 insertions(+), 24 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4289365a1aceb02adea5029beac1547e024ebca4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>