From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: webadmin: Fix selection of placeholder host devices in VmHostDevices
subtab
......................................................................
webadmin: Fix selection of placeholder host devices in VmHostDevices subtab
It wasn't possible to unassign VM host devices when the selection contained
IOMMU placeholder devices (which on their own cannot be removed).
Now we consider as "selected" only the primary (non-placeholder) host devices
and enable/disable the "Remove" button accordingly. Also on the backend are
sent only those "primary" devices as the current contract of
Add/RemoveVmHostDevices command expects that.
Change-Id: I33537c4039eee9c453ca330059420ae038129820
Bug-Url:
https://bugzilla.redhat.com/1343870
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/hostdev/VmHostDeviceListModel.java
1 file changed, 15 insertions(+), 19 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit
https://gerrit.ovirt.org/67271
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33537c4039eee9c453ca330059420ae038129820
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>