Alona Kaplan has submitted this change and it was merged.
Change subject: engine: remove nicName valdation from NetworkAttachment
......................................................................
engine: remove nicName valdation from NetworkAttachment
Via NetworkAttachment entity NIC cannot be created; it's only referenced.
Therefote, the 'NetworkAttachment.nicName' doesn't contain the new desired
name of a nic.
So there is no need to validate its length. The relevant command
should validate there is (or soon will be created) an interface with this
name.
Change-Id: Iba66a8c66a5570c1c6a81c00d83642e4b82cbf07
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Verified; Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/43660
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba66a8c66a5570c1c6a81c00d83642e4b82cbf07
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org