Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: extract the ClientStorage interface
......................................................................
userportal,webadmin: extract the ClientStorage interface
This patch makes the ClientStorage to be an interface (e.g. simply mockable)
and bound to a ClientStorageImpl class in the BaseSystemModule.
Change-Id: If5eaa942181c9df77278e736ddd6ac6b08e83fc7
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorage.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ClientStorageImpl.java
3 files changed, 108 insertions(+), 57 deletions(-)
Approvals:
Tomas Jelinek: Verified
Alexander Wels: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/26238
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5eaa942181c9df77278e736ddd6ac6b08e83fc7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server