Arik Hadas has submitted this change and it was merged. Change subject: core: Update getTotalMemorySizeInBytes ...................................................................... core: Update getTotalMemorySizeInBytes VM.getTotalMemorySizeInBytes apparently uses outdated value for computing VM's video RAM. This patch retrieves video RAM size from the corresponding helper. We must move the method to modules/bll so that we are able to use the video RAM size helper. We also renamed the method to be more distinctive from the recently introduced getTotalRequiredMemoryInMb method. Change-Id: I2f0fd1ae3f1894b51ee8983725c8763dafbb0503 Signed-off-by: Milan Zamazal <mzamazal@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 8 files changed, 32 insertions(+), 17 deletions(-) Approvals: Arik Hadas: Looks good to me, approved; Passed CI tests Milan Zamazal: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/56923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f0fd1ae3f1894b51ee8983725c8763dafbb0503 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>