Hello ovirt-engine-commits, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/14116 to review the following change. Change subject: findbugs: Classes that implements Comparator need to implement Serializable ...................................................................... findbugs: Classes that implements Comparator need to implement Serializable Change-Id: I9379d37a0a3913135e8387d7ff3462a38bdb0d8b Signed-off-by: Shahar Havivi <shavivi(a)redhat.com&gt; --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/14116/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java index 15ddb57..3dcc95c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java @@ -1270,7 +1270,7 @@ } } - public final static class InterfaceComparator implements Comparator<VdsNetworkInterface> { + public final static class InterfaceComparator implements Comparator<VdsNetworkInterface>, Serializable { LexoNumericComparator lexoNumeric = new LexoNumericComparator(); @@ -1281,7 +1281,7 @@ } - public final static class NetworkComparator implements Comparator<Network> { + public final static class NetworkComparator implements Comparator<Network>, Serializable { private LexoNumericComparator lexoNumeric = new LexoNumericComparator(); @@ -1298,7 +1298,7 @@ } } - public final static class ClusterNetworkModelComparator implements Comparator<ClusterNetworkModel> { + public final static class ClusterNetworkModelComparator implements Comparator<ClusterNetworkModel>, Serializable { private LexoNumericComparator lexoNumeric = new LexoNumericComparator(); -- To view, visit http://gerrit.ovirt.org/14116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9379d37a0a3913135e8387d7ff3462a38bdb0d8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com&gt; Gerrit-Reviewer: ovirt-engine-commits <engine-commits(a)ovirt.org&gt;