From Juan Hernandez <juan.hernandez@redhat.com>:

Juan Hernandez has submitted this change and it was merged. Change subject: Don't avoid reserved words in enum values text ...................................................................... Don't avoid reserved words in enum values text The SDK appends an underscore to generated names that conflict with Ruby reserved words. But it also does so for the text of enum values. This is wrong, in particular it is wrong for the 'InheritableBoolean' enum which has the following values currently: FALSE = 'false_'.freeze TRUE = 'true_'.freeze ... The 'false_' and 'true_' values are incorrect, as that isn't what the server generates or expects, they should be 'false' and 'true', without the underscore. This patch fixes that issue. Change-Id: I5141e2be962d123934a35d14349d685f14e3bcd8 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java A sdk/spec/inheritable_boolean_spec.rb 2 files changed, 31 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73504 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5141e2be962d123934a35d14349d685f14e3bcd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>