Roy Golan has submitted this change and it was merged. Change subject: core: hosted-engine: Lock the sd import exclusively ...................................................................... core: hosted-engine: Lock the sd import exclusively Add an exclusive lock on the hosted engine domain import to prevent it from interleaving. There is a race where the domain might be added but the TX isn't closed yet and another import can enter and pass the command validation. Small clean-up made to remove the redundant getBackend() and runVdsCommand(..) methods. Change-Id: I2b67db78433f3c0847e118ccb279d63a65986b34 Bug-Url: https://bugzilla.redhat.com/1293928 Bug-Url: https://bugzilla.redhat.com/1290518 Signed-off-by: Roy Golan <rgolan(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddNFSStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java 8 files changed, 143 insertions(+), 58 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b67db78433f3c0847e118ccb279d63a65986b34 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;