Alexander Wels has submitted this change and it was merged.
Change subject: engine,webadmin: various coverity issues
......................................................................
engine,webadmin: various coverity issues
- Fixed various noted coverity issues (CIDs):
- 1062151 (Removed unused field from test)
- 1201855 (Missing call to superclass)
- 1201865 (Removed duplicate expression in test)
- 1201860 (Removed entity from object that is already
defined in superclass)
- 1201857 (Missing call to superclass)
Change-Id: Ib3833e8420ab7040c02600f97e439c21487f2466
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M
backend/manager/modules/branding/src/test/java/org/ovirt/engine/core/branding/BrandingServletTest.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
5 files changed, 15 insertions(+), 30 deletions(-)
Approvals:
Alexander Wels: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/26936
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3833e8420ab7040c02600f97e439c21487f2466
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server