Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of custom properties ...................................................................... webadmin: Fix of custom properties This patch fixes two problems: * When user (not admin@internal) with VmCreator role tried to create new VM from snapshot (clone) it failed with "User is not authorized to perform this action." * When admin@internal tried to create new VM from snapshot (clone) and changed some custom properties in "Clone VM from Snapshot" dialog the new VM was anyway created without any custom properties. The cause was confusion between abandoned UnitVmModel#customProperties and UnitVmModel#customPropertySheet during model -> business entity serialization. #customPropertySheet is serialized in CoreUnitToVmBaseBuilder Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Bug-Url: https://bugzilla.redhat.com/1338943 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>