Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix disable of the entire edit disk popup when VM is running ...................................................................... webadmin: Fix disable of the entire edit disk popup when VM is running Change I14dcbfb50a6249de6380346469baa055f7130662 (937704c5) introduced the ReadOnlyDiskModel used for image upload purposes, to decide whether to disable the entire dialog it used the isEditEnabled() methods from the parent model which although the misleading does not mean that the entire panel should be disabled but whether properties that are no editable when the VM is up should be disabled, this cause the edit dialog to be disabled at all times. This fixes it by calling getIsModelDisabled() after the initial load of the data centers Change-Id: I274635fbf97f0af45c1b1170dce887d480424b74 Bug-Url: https://bugzilla.redhat.com/1349498 Signed-off-by: Tal Nisan <tnisan@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java 2 files changed, 3 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I274635fbf97f0af45c1b1170dce887d480424b74 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>