Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix NPE when committing a snapshot. ...................................................................... core: Fix NPE when committing a snapshot. A regression caused by commit 268152abf19fbd64fd867bc5e5e40a57996aedc7 made the commit snapshot to throw NPE when commiting a snapshot, since the new snapshot id has been created twice, once for the snapshots table and once for the vm_snapshot_id of the image. The fix set the parameter only once. Change-Id: If423dd90739cd14a66a7a62399f56465a2e30021 Bug-Url: https://bugzilla.redhat.com/981367 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If423dd90739cd14a66a7a62399f56465a2e30021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server