Omer Frenkel has submitted this change and it was merged. Change subject: core: Make VM disks editable ...................................................................... core: Make VM disks editable When a VM is updated the data from the database is compared to the updated VM object provided by the caller. But the VM object loaded from the database doesn't contain the list of disks, so if the caller provides an VM object that contains the list of disks the UpdateVM command will wrongly assume that the caller is trying to modify this list. To avoid this issue this patch marks the list of disks as editable, so that the UpdateVM command will ignore it. Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600 Bug-Url: https://bugzilla.redhat.com/1059713 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server