Liron Aravot has submitted this change and it was merged. Change subject: core: verify Live Merge image deletion on SPM ...................................................................... core: verify Live Merge image deletion on SPM Bug 1227497 described a case where the engine may forget that it has removed an image during Live Merge, causing a difficult-to-recover failure. The fix submitted did not work for block storage where the VM was running on a host other than the SPM, because the GetVolumeInfo verb used is not aware of block storage changes that take place on the SPM. To avoid this, we created a new SPM GetVolumeInfo command. Change-Id: Ie14a78a59312c3846be8dc3b1530aa5535c9fb9b Bug-Url: https://bugzilla.redhat.com/1302215 Related-To: https://bugzilla.redhat.com/1227497 Signed-off-by: Greg Padgett <gpadgett@redhat.com> Signed-off-by: Ala Hino <ahino@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DestroyImageCheckCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SPMGetVolumeInfoVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SPMGetVolumeInfoVDSCommand.java 5 files changed, 73 insertions(+), 10 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified Liron Aravot: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie14a78a59312c3846be8dc3b1530aa5535c9fb9b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>