Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Permission given to a group doesn't apply to its member (#847333) ...................................................................... engine: Permission given to a group doesn't apply to its member (#847333) This patch fixes creation of user_permission_permissions_view. The error was that user of a group doesn't get the same permissions that the group does have. The user gets its own specific permissions only. This happens because the view user_permissions_permissions_view uses user_flat_groups in a wrong way, the view is supposed to make a table of permissions connected to user_id as permission_view, but this view connects also subusers of groups to their group's permissions. It uses ad_element_id instead of use_id field, that's the reason why GetPermissionsByAdElementIdQuery returns only permissions on specific user without including its group permissions. Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e Signed-off-by: Yaniv Bronhaim <ybronhei@redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server