Omer Frenkel has submitted this change and it was merged. Change subject: webadmin: do not persist RunOnce boot sequence accidentally ...................................................................... webadmin: do not persist RunOnce boot sequence accidentally VmDeviceCommonUtils.updateVmDevicesBootOrder() method was using RunOnce boot sequence if vm.isRunOnce() is true. When called from VmDeviceUtils.updateBootOrderInVmDeviceAndStoreToDB() this caused RunOnce boot sequence to be persisted when attaching/detaching disks, adding/removing NICs etc. Do avoid this undesired behavior, VmDeviceCommonUtils.updateVmDevicesBootOrder() is no more using RunOnce boot sequence. The RunOnce boot sequence is passed to it only from VmInfoBuilder.buildVmBootSequence() that is called when VM is started. The result is used to boot the VM and never persisted. Note that VmDynamic.bootSequence is still persisted, this is done in another place. Change-Id: Ibfa685f8d81b67eff41234a450185879f5bbccfd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1209038 Signed-off-by: Shmuel Melamud <smelamud@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 29 insertions(+), 9 deletions(-) Approvals: Shmuel Leib Melamud: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfa685f8d81b67eff41234a450185879f5bbccfd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud@redhat.com> Gerrit-Reviewer: automation@ovirt.org