Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: plugins: add constant duplication check ...................................................................... setup: plugins: add constant duplication check Check for constants duplication in all constants.py files Change-Id: I5c7a1d419b658bb712e135b3e5c5a94341b8ac51 Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1263785 --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/core/duplicated_constants_check.py 3 files changed, 125 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c7a1d419b658bb712e135b3e5c5a94341b8ac51 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw@redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde@redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>