Daniel Erez has submitted this change and it was merged. Change subject: engine: Teardown image after verifying upload. ...................................................................... engine: Teardown image after verifying upload. When uploading an image finishes, the uploading session is revoked and the image is being verified in VDSM. currently in the revoking function (stopImageTransferSession) there's a call to teardown image, which makes it unreachable to VDSM when trying to verify it. Move the teardown call for after stopping the session. this way only when we finish using the image it will be teared down. If the stopImageTransferSession fails, don't tear down the image, as the session still alive, thus someone might still using it. Change-Id: I7b6587452c2d2879dd97ed2645dd4c348cb0175b Bug-Url: https://bugzilla.redhat.com/1352676 Signed-off-by: Amit Aviram <aaviram@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/60192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b6587452c2d2879dd97ed2645dd4c348cb0175b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>