Alona Kaplan has submitted this change and it was merged. Change subject: core: refactor: renamed variables + extracted creating map ...................................................................... core: refactor: renamed variables + extracted creating map • Map<String, List<NetworkType>> nicsToNetworks —> Map<String, List<NetworkType>> nicNameToNetworkTypesMap • Entry<String, List<NetworkType>> nicToNetworkTypes —> Entry<String, List<NetworkType>> nicNameToNetworkTypes • extracted code creating map into method createNicNameToNetworkTypesMap • added check for nicName nullity; it should not happen. If it happens, there's a bug in our code(about which we're immediately informed). Change-Id: I7e0a7875a3f5356455f132af23d56d62f00d1989 Signed-off-by: Martin Mucha <mmucha@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java 1 file changed, 34 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/36145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0a7875a3f5356455f132af23d56d62f00d1989 Gerrit-PatchSet: 58 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: automation@ovirt.org