From Liron Aravot <laravot@redhat.com>:

Liron Aravot has submitted this change and it was merged. Change subject: core: enable entity progress support for all steps ...................................................................... core: enable entity progress support for all steps Currently entity progress report is supported for commands that add a step by overriding getCommandStep() and getCommandStepSubjectEntities(). On flows adding steps using different infrastructures (like async task manager based flows) it may be required to report progress on the entities as well. The progress on the entity is a sum of the progress*entity weight for all the steps "related" to the entity (we currently use that on jobs that modifies an entity exclusively). Therefore In order to support entity progress report for all the steps, we need a progress for each of them and to support for adding the step subject entities. This patch includes the following changes: 1. Add support to include StepSubjectEntity list when adding any step. 2. Move the StepSubjectEntity handling to the JobRepository in order to reuse the code by all the callers. 3. Adding the step_progress view so that steps without progress report will be considered with progress of 100 when they are finished. 4. Update to the entity_step_progress accordingly. Change-Id: I1511291b18dbbb6e11f715a9a1e203c839cbaffa Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/JobRepositoryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepSubjectEntity.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql 12 files changed, 129 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1511291b18dbbb6e11f715a9a1e203c839cbaffa Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>