Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove useless RpmVersionUtilsTest asserts ...................................................................... core: Remove useless RpmVersionUtilsTest asserts Removed asserts from negative test cases that throw exceptions. In these methods the splitRpmToParts call does not return any value, it throws an exception. As such, the assertEquals call is useless, and just adds confusion to the test. Change-Id: I652b29247139a8f961dfc5837e0ab4da2dcbbb63 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/RpmVersionUtilsTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I652b29247139a8f961dfc5837e0ab4da2dcbbb63 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: automation@ovirt.org