Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix NPE in Edit VM dialog ...................................................................... webadmin: Fix NPE in Edit VM dialog NPE was thrown when Edit VM dialog was opened by selecting the vm followed by multiple clicks on action button (toolbar above table of vms) "Edit". The problem was in InstanceImagesModel#getAllCurrentDisks() that failed if getItems() returned `null` and in ExistingVmModelBehavior#updateInstanceImages$1.onSuccess that calls `lineModel.initialize` and thus transitively InstanceImagesModel#getAllCurrentDisks() before `getModel().getInstanceImages().setItems()` is called. Change-Id: Idf986bf074a7bb4259ac1707e35916151d5788c2 Bug-Url: https://bugzilla.redhat.com/1326311 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf986bf074a7bb4259ac1707e35916151d5788c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>