Change in ovirt-engine[master]: core: Remove VdsStaticDao from VdsDynamicDaoTest

From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80282 ) Change subject: core: Remove VdsStaticDao from VdsDynamicDaoTest ...................................................................... core: Remove VdsStaticDao from VdsDynamicDaoTest VdsDynamicDaoTest should rely only on VdsDyanmicDao, not other DAOs. Since the only interaction with VdsStatic this test now has is to use the predefined ID, this dependency can now be removed. As an additional bonus, removing this DAO call from the setUp also speeds up the test. Change-Id: I026d1f6efb222e1388a7f15587489cd566080237 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDaoTest.java 1 file changed, 20 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I026d1f6efb222e1388a7f15587489cd566080237 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review