Tal Nisan has submitted this change and it was merged. Change subject: core: VM Numa command test setup unification ...................................................................... core: VM Numa command test setup unification Reworked the VM numa command test classes to have a unified setup, as they all currently copy-paste very similar boiler-plate code. As part of this reworking, a single command instance is annotated with a @Spy annotation in order to prepare this test for injecting DAOs as done in the subsequent patches. With this patch, the class is left with a single command instance which has a single instance of a list of numa nodes. Since these issues remain between tests, they need to be cleaned up in an @After method. Change-Id: Id6e9746f4cba3767e4948ae066149226927ee352 Signed-off-by: Allon Mureinik <amureini@redhat.com> Signed-off-by: Tal Nisan <tnisan@redhat.com> --- A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommandTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java 5 files changed, 226 insertions(+), 398 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6e9746f4cba3767e4948ae066149226927ee352 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>