Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate shareable disk version ...................................................................... core: Validate shareable disk version Changing the validation of shareable disk to check the prior returnValue indication also. Also change the validation version method to get the storage pool version as a parameter when validating if version supported, Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> Change-Id: Ie491f5000f1fdcb2ded820c81dee34e6b191ad62 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 4 files changed, 16 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie491f5000f1fdcb2ded820c81dee34e6b191ad62 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com>