Allon Mureinik has submitted this change and it was merged. Change subject: engine: Clear IDE disk address on bootable change ...................................................................... engine: Clear IDE disk address on bootable change In the following scenario, the VM will fail to start: 1. Create new VM with IDE disk, verify it starts 2. Add second IDE disk 3. Turn off bootable flag from 1st disk, make 2nd disk bootable 4. Start the VM The root cause of this issue is that we save the device address of the disk, but we changed the order of the disks. This will cause a mismatch between the address and the name of the disk. In order to fix this issue, the address will be cleared for IDE disks if the 'bootable' attribute changed. Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Bug-Url: https://bugzilla.redhat.com/1186817 Signed-off-by: Fred Rolland <frolland@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/63726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Fred Rolland <frolland@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>